-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109700: Improve stress tests for interpreter creation #109946
Open
serhiy-storchaka
wants to merge
4
commits into
python:main
Choose a base branch
from
serhiy-storchaka:test_interpreters-test_create_many_threaded
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
gh-109700: Improve stress tests for interpreter creation #109946
serhiy-storchaka
wants to merge
4
commits into
python:main
from
serhiy-storchaka:test_interpreters-test_create_many_threaded
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Sep 27, 2023
•
edited
Loading
edited
- Ensure that destructors are called in the test that created interpreters, not after finishing it.
- Try to create interpreters simultaneously in test_create_many_threaded.
- Mark test_create_many_threaded that requires over 6GB of memory as bigmemtest.
- Issue: test_interpreters: test_create_many_threaded() failed on FreeBSD: log: RuntimeError: interpreter creation failed #109700
serhiy-storchaka
changed the title
WIP: gh-109700: Make stress tests on interpreter creation more stressful
gh-109700: Improve stress tests on interpreter creation
Nov 8, 2023
serhiy-storchaka
added
skip news
needs backport to 3.11
only security fixes
needs backport to 3.12
bug and security fixes
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
and removed
needs backport to 3.11
only security fixes
labels
Nov 8, 2023
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 6aecbf9 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
label
Nov 8, 2023
serhiy-storchaka
changed the title
gh-109700: Improve stress tests on interpreter creation
gh-109700: Improve stress tests for interpreter creation
Nov 8, 2023
While leaks are not yet fixed, we want to minimize effect of these tests on other tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting core review
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
skip news
tests
Tests in the Lib/test dir
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.