Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108562: turn off false-positive -Wstringop-overflow in word_to_string() #116346

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Mar 5, 2024

@skirpichev
Copy link
Member Author

@skrah, could you take look on this variant of solving #108562? Attempt to enable -fstrict=overflow was unsuccessful, unfortunately.

@rhettinger rhettinger removed their request for review March 5, 2024 04:50
@skirpichev

This comment was marked as outdated.

@skirpichev
Copy link
Member Author

skirpichev commented Oct 6, 2024

@vstinner, maybe you could review this little pr? Note, that 4.0.0 has more diagnostic ignored (at top of the file):

#if defined(__GNUC__) && !defined(__INTEL_COMPILER) && __GNUC__ >= 7
  #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
  #pragma GCC diagnostic ignored "-Wmisleading-indentation"
  #pragma GCC diagnostic ignored "-Warray-bounds"
#endif

I turn of one diagnostic and more locally (with following pop directive).

Another option (mentioned in the issue) - update bundled copy.

@vstinner
Copy link
Member

vstinner commented Oct 7, 2024

Modules/_decimal/libmpdec/io.c

libmpdec/ is vendored copy of a 3rd party project. You should fix the issue in the upstream first. Otherwise, it will be lost at the next update.

See upstream: https://www.bytereef.org/mpdecimal/.

@skirpichev
Copy link
Member Author

Ok, then I close pr and issue.

Unfortunately, @skrah blocked in python's repos. But he is aware about issue anyway.

@skirpichev skirpichev closed this Oct 7, 2024
@skirpichev skirpichev deleted the decimal-io.c-off-stringop-overflow-108562 branch October 7, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants