-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kenjin tier2 inliner redux #116394
Kenjin tier2 inliner redux #116394
Conversation
…on into tier2_inliner_redux
Python/ceval.c
Outdated
// Make sure that this is, indeed, the top frame. We can't check this in | ||
// _PyThreadState_PopFrame, since f_code is already cleared at that point: | ||
assert((PyObject **)frame + _PyFrame_GetCode(frame)->co_framesize == | ||
tstate->datastack_top); | ||
// // Make sure that this is, indeed, the top frame. We can't check this in | ||
// // _PyThreadState_PopFrame, since f_code is already cleared at that point: | ||
// assert((PyObject **)frame + _PyFrame_GetCode(frame)->co_framesize == | ||
// tstate->datastack_top); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously this block should just be deleted. I'm leaving it in because it seems a kind of important check, but I don't know how to reproduce it now that datastack_top may be larger than the end of the reserved stack space due to call inlining.
6c63c21
to
dad9100
Compare
396223a
to
2f9539b
Compare
@Fidget-Spinner Could you merge this in your PR's branch? |
Closing,nNow that this is merged into gh-116290. |
Like Fidget-Spinner#72 but without main merge.