-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101100: Fix Sphinx warnings in library/faulthandler.rst
#118353
gh-101100: Fix Sphinx warnings in library/faulthandler.rst
#118353
Conversation
PR title is interesting 👀 |
Haha, it was a mistake, corrected now! I had some extra stuff on |
library/faulthandler.rst
:c:func:`!_exit` with status=1 after dumping the tracebacks. (Note | ||
:c:func:`!_exit` exits the process immediately, which means it doesn't do any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same as https://docs.python.org/3/library/os.html#os._exit? Should this link to that, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, it's calling the C one from unistd.h
:
cpython/Modules/faulthandler.c
Line 11 in e0ab642
# include <unistd.h> // _exit() |
cpython/Modules/faulthandler.c
Lines 591 to 592 in e0ab642
if (thread.exit) | |
_exit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think os._exit
is just a very thin wrapper around the C one:
Lines 6613 to 6619 in e0ab642
static PyObject * | |
os__exit_impl(PyObject *module, int status) | |
/*[clinic end generated code: output=116e52d9c2260d54 input=5e6d57556b0c4a62]*/ | |
{ | |
_exit(status); | |
return NULL; /* Make gcc -Wall happy */ | |
} |
But yes, good point, they're not exactly the same!
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…ythonGH-118353) (cherry picked from commit 33c6cf3) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-118366 is a backport of this pull request to the 3.12 branch. |
Fix 13 warnings:
Link the
SIG*
py:const
s to thesignal
module, and add!
to thec:func
s which I don't think need documenting.📚 Documentation preview 📚: https://cpython-previews--118353.org.readthedocs.build/