Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-118910: Less boilerplate in the tier 2 optimizer #118913

Merged
merged 5 commits into from
May 10, 2024
Merged

GH-118910: Less boilerplate in the tier 2 optimizer #118913

merged 5 commits into from
May 10, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented May 10, 2024 •
edited by bedevere-app bot
Loading

Removes about 50 lines of written code and another 150 of generated code.

@bedevere-app bedevere-app bot mentioned this pull request May 10, 2024
Closed
Fidget-Spinner
Fidget-Spinner reviewed May 10, 2024
View reviewed changes
Python/optimizer_analysis.c Outdated Show resolved Hide resolved
Python/optimizer_analysis.c Show resolved Hide resolved
@markshannon @Fidget-Spinner
Update Python/optimizer_analysis.c
50dbf72 
Co-authored-by: Ken Jin <kenjin4096@gmail.com>
@markshannon markshannon merged commit f5c6b99 into python:main May 10, 2024
62 checks passed
gvanrossum
gvanrossum reviewed May 10, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I have one question: it looks like _Py_uop_sym_new_unknown may return NULL, unlike the other _Py_uop_sym_new_xxx variants, and not every call site checks for that.

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@markshannon @estyxx
pythonGH-118910: Less boilerplate in the tier 2 optimizer (python#118913
2dd3442 
)
@markshannon markshannon deleted the less-boilerplate-optimizer branch August 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @gvanrossum @Fidget-Spinner