Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-120662: improve smtplib example #120668

Merged
merged 6 commits into from
Jun 18, 2024
Merged

gh-120662: improve smtplib example #120668

merged 6 commits into from
Jun 18, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Jun 18, 2024 •
edited by github-actions bot
Loading

@picnixz picnixz requested a review from a team as a code owner June 18, 2024 09:02
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jun 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 18, 2024
Closed
AlexWaygood
AlexWaygood reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Doc/library/smtplib.rst Outdated Show resolved Hide resolved
Doc/library/smtplib.rst Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not an email expert, so I'll leave it a few days before merging in case anybody else wants to chime in 👍

(Feel free to ping me if it's been a week and I've forgotten!)

@AlexWaygood AlexWaygood added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 18, 2024
hugovk
hugovk reviewed Jun 18, 2024
View reviewed changes
Doc/library/smtplib.rst Outdated Show resolved Hide resolved
Doc/library/smtplib.rst Outdated Show resolved Hide resolved
Doc/library/smtplib.rst Outdated Show resolved Hide resolved
@picnixz
Copy link
Contributor Author

picnixz commented Jun 18, 2024

Thank you Alex & Hugo for your comments by the way! at the beginning, I should either have left out any stylistic changes (e.g., PEP 8 / f-strings etc) and focused on fixing the EOF-issue or should have been more consistent with the remaining style!

@picnixz @AlexWaygood
Update Doc/library/smtplib.rst
1547a61 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@picnixz
Copy link
Contributor Author

picnixz commented Jun 18, 2024 •
edited
Loading

By the way, I left out the context-manager usage, but I can put it (though, for a "simple example" maybe the explicit constructions are easier to follow for a beginner)

@vstinner vstinner merged commit 4bc27ab into python:main Jun 18, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
@picnixz @AlexWaygood @miss-islington
pythongh-120662: Improve smtplib example (pythonGH-120668)
6e93237 
(cherry picked from commit 4bc27ab)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
@picnixz @AlexWaygood @miss-islington
pythongh-120662: Improve smtplib example (pythonGH-120668)
ce397d8 
(cherry picked from commit 4bc27ab)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2024

GH-120681 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2024

GH-120682 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 18, 2024
@vstinner
Copy link
Member

Merged, thanks @picnixz.

@picnixz picnixz deleted the improve-smtplib-docs-example branch June 18, 2024 11:59
vstinner pushed a commit that referenced this pull request Jun 18, 2024
@miss-islington @picnixz @AlexWaygood
[3.12] gh-120662: Improve smtplib example (GH-120668) (#120682)
70d71fb 
gh-120662: Improve `smtplib` example (GH-120668)
(cherry picked from commit 4bc27ab)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
vstinner pushed a commit that referenced this pull request Jun 18, 2024
@miss-islington @picnixz @AlexWaygood
[3.13] gh-120662: Improve smtplib example (GH-120668) (#120681)
36b0052 
gh-120662: Improve `smtplib` example (GH-120668)
(cherry picked from commit 4bc27ab)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@picnixz @AlexWaygood
pythongh-120662: Improve smtplib example (python#120668)
6000b89 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@picnixz @AlexWaygood @mrahtz
pythongh-120662: Improve smtplib example (python#120668)
15e8c95 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@picnixz @AlexWaygood @noahbkim
pythongh-120662: Improve smtplib example (python#120668)
3d861d5 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@picnixz @AlexWaygood @estyxx
pythongh-120662: Improve smtplib example (python#120668)
bb5e008 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picnixz @vstinner @hugovk @AlexWaygood