Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121040: Remove fallthrough warnings compiler option #121041

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

nohlson
Copy link
Contributor

@nohlson nohlson commented Jun 26, 2024

Until tooling is implemented remove -Wimplicit-fallthrough compiler flag from BASEFLAGS

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@corona10 corona10 changed the title gh-#121040: Remove fallthrough warnings gh-121040: Remove fallthrough warnings Jun 26, 2024
@corona10 corona10 enabled auto-merge (squash) June 26, 2024 09:45
@corona10 corona10 disabled auto-merge June 26, 2024 09:45
@corona10 corona10 enabled auto-merge (squash) June 26, 2024 09:45
@corona10 corona10 changed the title gh-121040: Remove fallthrough warnings gh-121040: Remove fallthrough warnings compiler option Jun 26, 2024
@corona10 corona10 merged commit ef28f6d into python:main Jun 26, 2024
38 checks passed
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants