Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120838: Make Sure Py_Finalize() Always Runs Against the Main Interpreter #121063

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 26, 2024

We can't easily force Py_Finalize() to run in the main thread (especially because of Py_Exit()), but we can at least ensure the main interpreter is active.

(We'll be backporting this since the fix for gh-120765 needs it.)

@ericsnowcurrently
Copy link
Member Author

FYI, this causes gh-120765 to be triggered more often, so we'll need to fold it into the fix for that issue: gh-121060.

@ericsnowcurrently ericsnowcurrently marked this pull request as draft June 26, 2024 20:44
@ericsnowcurrently ericsnowcurrently deleted the py-finalize-ensure-main-interp branch June 26, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.13 bugs and security fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant