Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() #13816

Merged
merged 1 commit into from
Jun 4, 2019
Merged

bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() #13816

merged 1 commit into from
Jun 4, 2019
+6 −2

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 4, 2019 •
edited by bedevere-bot
Loading

test_venv.test_mutiprocessing() now explicitly calls pool.terminate()
to wait until the pool completes.

https://bugs.python.org/issue37153

@vstinner
bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate()
d1f01e7 
test_venv.test_mutiprocessing() now explicitly calls pool.terminate()
to wait until the pool completes.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 4, 2019
@vstinner vstinner merged commit bc6469f into python:master Jun 4, 2019
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

@vstinner vstinner deleted the test_venv_mp branch June 4, 2019 17:03
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @vstinner, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bc6469f79ca13217b784fb47da7ec83484a3debe 3.7

@vstinner vstinner mentioned this pull request Jun 4, 2019
Closed
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2019
@vstinner @miss-islington
bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() (py…
9236f83 
…thonGH-13816)

test_venv.test_mutiprocessing() now explicitly calls pool.terminate()
to wait until the pool completes.
(cherry picked from commit bc6469f)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

GH-13819 is a backport of this pull request to the 3.7 branch.

vstinner added a commit that referenced this pull request Jun 4, 2019
@miss-islington @vstinner
bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() (GH…
5f8443e 
…-13816) (GH-13819)

test_venv.test_mutiprocessing() now explicitly calls pool.terminate()
to wait until the pool completes.
(cherry picked from commit bc6469f)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() (py…
0cbe8bb 
…thonGH-13816)

test_venv.test_mutiprocessing() now explicitly calls pool.terminate()
to wait until the pool completes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni