Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-37335, test_c_locale_coercion: Remove unnecessary code (GH-14447) #14552

Merged
merged 1 commit into from
Jul 2, 2019
Merged

[3.8] bpo-37335, test_c_locale_coercion: Remove unnecessary code (GH-14447) #14552

merged 1 commit into from
Jul 2, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 2, 2019 •
edited by bedevere-bot
Loading

Python initialization now ensures that sys stream encoding
names are always normalized by codecs.lookup(encoding).name.
Simplify test_c_locale_coercion: it doesn't have to normalize
encoding names anymore.
(cherry picked from commit 61bf97e)

Co-authored-by: Jakub Kulík Kulikjak@gmail.com

https://bugs.python.org/issue37335

@kulikjak @miss-islington
bpo-37335, test_c_locale_coercion: Remove unnecessary code (pythonGH-…
3db39ab 
…14447)

Python initialization now ensures that sys stream encoding
names are always normalized by codecs.lookup(encoding).name.
Simplify test_c_locale_coercion: it doesn't have to normalize
encoding names anymore.
(cherry picked from commit 61bf97e)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jul 2, 2019
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 2, 2019
vstinner
vstinner approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@kulikjak and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 518dc94 into python:3.8 Jul 2, 2019
@miss-islington miss-islington deleted the backport-61bf97e-3.8 branch July 2, 2019 11:18
@miss-islington
Copy link
Contributor Author

@kulikjak and @vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@kulikjak and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @kulikjak