bpo-37834: Prevent shutil.rmtree exception #15602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when built on non-Windows system without fd system call support, like older versions of macOS.
|
Looks fine. Tests pass, manually tested on Windows, too. |
|
Thanks @ned-deily for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
Thanks @ned-deily for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry @ned-deily and @ambv, I had trouble checking out the |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Aug 29, 2019
when built on non-Windows system without fd system call support, like older versions of macOS. (cherry picked from commit 7fcc208) Co-authored-by: Ned Deily <nad@python.org>
|
GH-15603 is a backport of this pull request to the 3.8 branch. |
ambv
added a commit
that referenced
this pull request
Aug 29, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
when built on non-Windows system without fd system call support, like older versions of macOS.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
when built on non-Windows system without fd system call support, like older versions of macOS.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
when built on non-Windows system without fd system call support, like older versions of macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when built on non-Windows system without fd system call support,
like older versions of macOS.
https://bugs.python.org/issue37834