Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28401: prevent Py_DEBUG builds from trying to import limited ABI modules #1766

Merged
merged 2 commits into from
Nov 16, 2018
Merged

bpo-28401: prevent Py_DEBUG builds from trying to import limited ABI modules #1766

merged 2 commits into from
Nov 16, 2018

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented May 23, 2017 •
edited by bedevere-bot
Loading

Issue 28401: Don't attempt to import the stable API extensions, they are not supported in PyDEBUG builds (which don't implement that ABI).

https://bugs.python.org/issue28401

@mention-bot
Copy link

@stefanor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @loewis and @warsaw to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@stefanor stefanor changed the title PyDEBUG builds don't support the limited ABI PyDEBUG builds don't support the limited ABI bpo-28401 May 23, 2017
@stefanor
Copy link
Contributor Author

this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings

That was it.

@brettcannon brettcannon changed the title PyDEBUG builds don't support the limited ABI bpo-28401 bpo-28401: PyDEBUG builds don't support the limited ABI May 23, 2017
@brettcannon brettcannon self-requested a review May 23, 2017 18:20
@brettcannon brettcannon changed the title bpo-28401: PyDEBUG builds don't support the limited ABI bpo-28401: prevent Py_DEBUG builds from trying to import limited ABI module May 23, 2017
@brettcannon brettcannon changed the title bpo-28401: prevent Py_DEBUG builds from trying to import limited ABI module bpo-28401: prevent Py_DEBUG builds from trying to import limited ABI modules May 23, 2017
@Mariatta Mariatta closed this Jul 5, 2018
@Mariatta Mariatta reopened this Jul 5, 2018
@Mariatta Mariatta mentioned this pull request Jul 5, 2018
Closed
@brettcannon
Copy link
Member

@stefanor sorry, this simply fell through the cracks. Could you add a NEWS entry file?

@brettcannon brettcannon reopened this Jul 20, 2018
brettcannon
brettcannon requested changes Jul 20, 2018
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a news entry.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@stefanor
PyDEBUG builds don't support the limited ABI
1ef0d5f 
Issue: 28401: Don't attempt to import the stable API extensions, they
are not supported in PyDEBUG builds (which don't implement that ABI).
@stefanor
Copy link
Contributor Author

stefanor commented Nov 3, 2018

Rebased (so that blurb was supported) and added a NEWS entry.

@miss-islington
Copy link
Contributor

@stefanor: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 338d54f into python:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stefanor @mention-bot @the-knights-who-say-ni @brettcannon @bedevere-bot @miss-islington @Mariatta