bpo-1635741: Port _collections module to multiphase initialization. #19074
Conversation
|
For the record, I will work on a new helper function after this PR is landed if this work is worth to do. |
|
@shihai1991 Please take a look :) |
| if (PyType_Ready(type) < 0) { | ||
| return -1; | ||
| } | ||
| const char *name = _PyType_Name(type); |
There was a problem hiding this comment.
FYI I checked manually that the actual type name and _PyType_Name() gives the same name than before this change.
There was a problem hiding this comment.
I did same thing also :) Thank you for the re-checking!
Modules/_collectionsmodule.c
Outdated
| } | ||
| const char *name = _PyType_Name(type); | ||
| Py_INCREF(type); | ||
| if (PyModule_AddObject(m, name, (PyObject *)type) < 0) { |
There was a problem hiding this comment.
Checking for PyModule_AddObject() error is a good thing ;-)
Modules/_collectionsmodule.c
Outdated
| _COLLECTIONS__COUNT_ELEMENTS_METHODDEF | ||
| {NULL, NULL} /* sentinel */ | ||
| }; | ||
|
|
||
| static int | ||
| collections_exec(PyObject *m) { |
There was a problem hiding this comment.
nitpick: would you mind to rename it to "mod" or "module"?
There was a problem hiding this comment.
module might be great! Thanks for the suggestion
|
oh, on~ my network crashed at this point :( |
|
|
||
| defdict_type.tp_base = &PyDict_Type; | ||
|
|
||
| for (int i = 0; typelist[i] != NULL; i++) { |
|
Thanks for the reviews :) |
https://bugs.python.org/issue1635741