Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29590: fix stack trace for gen.throw() with yield from #19896

Merged
merged 2 commits into from
Jul 9, 2020
Merged

bpo-29590: fix stack trace for gen.throw() with yield from #19896

merged 2 commits into from
Jul 9, 2020
+61 −0

Conversation

cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented May 4, 2020 •
edited by bedevere-bot
Loading

This fixes the following issue: When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.

https://bugs.python.org/issue29590

@cjerdonek
Add failing test.
75baa96
@cjerdonek
bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)
8dda934 
When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
@cjerdonek cjerdonek requested a review from 1st1 as a code owner May 4, 2020 06:54
@cjerdonek cjerdonek changed the title [WIP] bpo-29590: fix stack trace for gen.throw() with yield from bpo-29590: fix stack trace for gen.throw() with yield from May 4, 2020
@markshannon
Copy link
Member

LGTM.

@markshannon markshannon merged commit 8b33961 into python:master Jul 9, 2020
@miss-islington
Copy link
Contributor

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@markshannon: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot
Copy link

GH-21416 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 9, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
@cjerdonek @miss-islington
bpo-29590: fix stack trace for gen.throw() with yield from (pythonGH-…
7bdcac5 
…19896)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @cjerdonek and @markshannon, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8b33961e4bc4020d8b2d5b949ad9d5c669300e89 3.8

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@cjerdonek @arun-mani-j
bpo-29590: fix stack trace for gen.throw() with yield from (python#19896
0b6c158 
)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@cjerdonek @shihai1991
bpo-29590: fix stack trace for gen.throw() with yield from (python#19896
3d19985 
)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
@Mariatta Mariatta added the needs backport to 3.9 only security fixes label Sep 4, 2020
@miss-islington
Copy link
Contributor

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2020
@cjerdonek @miss-islington
bpo-29590: fix stack trace for gen.throw() with yield from (pythonGH-…
63d31bc 
…19896)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
@bedevere-bot
Copy link

GH-22106 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 4, 2020
@miss-islington
Copy link
Contributor

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @cjerdonek and @markshannon, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8b33961e4bc4020d8b2d5b949ad9d5c669300e89 3.8

@Mariatta
Copy link
Member

Mariatta commented Sep 4, 2020

Someone has to manually backport to the 3.8 branch. (I'm not doing it)

miss-islington added a commit that referenced this pull request Sep 4, 2020
@miss-islington @cjerdonek
bpo-29590: fix stack trace for gen.throw() with yield from (GH-19896)
e92219d 
* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
@jbower-fb jbower-fb mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Assignees

@markshannon markshannon

Labels
needs backport to 3.9 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjerdonek @markshannon @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni