Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Document vars behavior when __dict__ is missing #21466

Merged
merged 1 commit into from
Aug 21, 2020
Merged

[doc] Document vars behavior when __dict__ is missing #21466

merged 1 commit into from
Aug 21, 2020

Conversation

andresdelfino
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 13, 2020
facundobatista
facundobatista approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@facundobatista
Copy link
Member

Closing and reopening to awake Travis.

@facundobatista facundobatista merged commit 802726a into python:master Aug 21, 2020
@bedevere-bot
Copy link

@facundobatista: Please replace # with GH- in the commit message next time. Thanks!

@facundobatista facundobatista added the needs backport to 3.9 only security fixes label Aug 21, 2020
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @facundobatista for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2020
@andresdelfino @miss-islington
Document vars behavior when __dict__ is missing (pythonGH-21466)
79d6f57 
(cherry picked from commit 802726a)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 21, 2020
@bedevere-bot
Copy link

GH-21939 is a backport of this pull request to the 3.9 branch.

@andresdelfino andresdelfino deleted the vars_typerror_doc branch August 21, 2020 22:32
facundobatista pushed a commit that referenced this pull request Aug 22, 2020
@miss-islington @andresdelfino
Document vars behavior when __dict__ is missing (GH-21466) (GH-21939)
d7cd116 
(cherry picked from commit 802726a)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @facundobatista for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-21941 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2020
@andresdelfino @miss-islington
Document vars behavior when __dict__ is missing (pythonGH-21466)
d9b7d20 
(cherry picked from commit 802726a)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
facundobatista pushed a commit that referenced this pull request Aug 22, 2020
@miss-islington @andresdelfino
Document vars behavior when __dict__ is missing (GH-21466) (GH-21941)
0804539 
(cherry picked from commit 802726a)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@andresdelfino
Document vars behavior when __dict__ is missing (python#21466)
201c4bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundobatista facundobatista facundobatista approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andresdelfino @facundobatista @bedevere-bot @miss-islington @eamanu @the-knights-who-say-ni @nanjekyejoannah