Update all Python Cookbook links after migration to GitHub #22205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresdelfino
requested review from
lysnikolaou,
pablogsal and
rhettinger
as code owners
ammaraskar
approved these changes
Sep 15, 2020
pablogsal
approved these changes
Sep 15, 2020
|
Question, will it be better to show the raw text instead of the GitHub page? So basically: instead of |
I think the hightlighting is nice feature, and I'm not sure we are gaining something with the raw content. |
Extra clarity and less clutter. Also, to link against the resource directly and not to GitHub page with all the extras. In the later, you need JavaScript and you can not use curl or simple parsers to query it for instance. I don't feel very strongly though. |
|
@pablogsal just pushed a commit to use raw links. |
|
For what it's worth the original activestate links had some additional context in the form of the author and description: https://web.archive.org/web/20100213000236/https://code.activestate.com/recipes/52560/ This is easier to discover using the github link rather than the raw link, i.e clicking up to the parent folder https://github.com/ActiveState/code/tree/master/recipes/Python/456195_urrlib2_opener_SSL_proxy_CONNECT will let you see it |
That's a good point indeed. I am good either way then. If you want the previous version, you can remove the commit or you can leave it as it is. Just tell me when you think is ready and I will land it |
andresdelfino
force-pushed
the
fix_recipes
branch
from
9056e86
to
86ca9e8
Compare
|
@pablogsal I also think @ammaraskar has a point. I deleted the second commit. This can be merged when you see fit. |
|
|
It seems the issue with test_logging is known, as I was added to the noisy list of these issues: https://bugs.python.org/issue6721 |
|
@pablogsal this may have to be reverted. I just tried again and the old links work. The old links have the benefit of the comments, where multiple solutions are proposed. It seems there was a problem in the Web site when I tested it and opened the PR: |
Could you make a PR for the revert? |
Sure! |
andresdelfino
added a commit
to andresdelfino/cpython
that referenced
this pull request
Sep 26, 2020
This reverts commit ac0333e.
pablogsal
pushed a commit
that referenced
this pull request
Sep 27, 2020
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Sep 29, 2020
* origin/master: (113 commits) bpo-41773: Raise exception for non-finite weights in random.choices(). (pythonGH-22441) bpo-41873: Add vectorcall for float() (pythonGH-22432) bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428) bpo-41842: Add codecs.unregister() function (pythonGH-22360) bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433) bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337) bpo-41870: Use PEP 590 vectorcall to speed up bool() (pythonGH-22427) [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340) bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417) bpo-41858: Clarify line in optparse doc (pythonGH-22407) Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424) bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415) bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416) Fix logging error message (pythonGH-22410) bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395) bpo-41775: Make 'IDLE Shell' the shell title (python#22399) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) ...
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This commit reverts commit ac0333e as the original links are working again and they provide extended features such as comments and alternative versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveState announced it was migrating recipes to GitHub on 2017:
https://www.activestate.com/blog/code-recipes-now-github-5000-recipes-python-perl-ruby-and-more/
They are no longer available at their original URLs.
Fixed all links.