-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-42598: Fix implicit function declarations in configure #23690
bpo-42598: Fix implicit function declarations in configure #23690
Conversation
This is invalid in C99 and later and is an error with some compilers (e.g. clang in Xcode 12), and can thus cause configure checks to produce incorrect results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
GH-23756 is a backport of this pull request to the 3.9 branch. |
|
Re buildbot failure above: I compared the results of this run (853) on the buildbot to the previous run (852) and didn't see any obvious differences other than the test_asyncio environment changed warning. Since test_asyncio is known to be finicky, I am going to ignore this failure for now. |
Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-23757 is a backport of this pull request to the 3.8 branch. |
…23690) This is invalid in C99 and later and is an error with some compilers (e.g. clang in Xcode 12), and can thus cause configure checks to produce incorrect results.
This is invalid in C99 and later and is an error with some compilers
(e.g. clang in Xcode 12), and can thus cause configure checks to
produce incorrect results.
Rather than including stdlib.h for the
exit
calls, I just changed them toreturn
since they are all in main() anyway.https://bugs.python.org/issue42598