-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40170: Convert PyDescr_IsData macro to C function #24535
Merged
vstinner
merged 5 commits into
python:master
from
erlend-aasland:bpo-40170/PyDescr_IsData
Feb 16, 2021
Merged
bpo-40170: Convert PyDescr_IsData macro to C function #24535
vstinner
merged 5 commits into
python:master
from
erlend-aasland:bpo-40170/PyDescr_IsData
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vstinner Would you mind reviewing this? |
vstinner
reviewed
Feb 15, 2021
Misc/NEWS.d/next/Core and Builtins/2021-02-15-13-41-14.bpo-40170.r2FAtl.rst
Outdated
Show resolved
Hide resolved
vstinner
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks, @vstinner! |
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
Feb 17, 2021
…to "C API" section
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro accessed the PyTypeObject.tp_descr_set member.
Reimplemented as a C function to hide implementation details.
https://bugs.python.org/issue40170