Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40170: Convert PyDescr_IsData macro to C function #24535

Merged
merged 5 commits into from
Feb 16, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 15, 2021

The macro accessed the PyTypeObject.tp_descr_set member.
Reimplemented as a C function to hide implementation details.

https://bugs.python.org/issue40170

@erlend-aasland
Copy link
Contributor Author

@vstinner Would you mind reviewing this?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland
Copy link
Contributor Author

Thanks, @vstinner!

@vstinner vstinner merged commit 871eb42 into python:master Feb 16, 2021
@erlend-aasland erlend-aasland deleted the bpo-40170/PyDescr_IsData branch February 16, 2021 08:32
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 17, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants