bpo-30861: Return StreamReeader remaining buffer before raise excepiton #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS. Let's keep the discussion in the bpo issue (http://bugs.python.org/issue30861). |
1st1
reviewed
May 29, 2018
| @@ -571,6 +571,11 @@ def readuntil(self, separator=b'\n'): | |||
| self._buffer.clear() | |||
| raise IncompleteReadError(chunk, None) | |||
There was a problem hiding this comment.
I don't like the fact that this code path can swallow the previously set self._exception.
|
Could you please rebase your PR against the latest master branch? |
|
Superseded by #7473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of StreamReader does not take care of the status of the buffer, once an exception has been set via
set_exceptionany call to the read methods won't be able to get the missing data still pending to be processed.From the point of view of the developer, if there is no scheduled task for waiting for data into the Streamreader between a network data gets into the buffer socket and a closing connection by the other peer arrives, the developer won't be able to gather the previous data.
This PR take care first of the remaining buffer and try to return first to the user, and only when the buffer has run out raises the proper exception