Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ssl module OP_NO_* deprecation warning message #26599

Closed
wants to merge 1 commit into from
Closed

fix ssl module OP_NO_* deprecation warning message #26599

wants to merge 1 commit into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Jun 8, 2021 •
edited
Loading

The error message prints out "is deprecated is deprecated" because of an earlier format template

@graingert
Copy link
Contributor Author

@tiran

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jun 8, 2021 •
edited
Loading

Thanks for the report and PR! Can you please reference the issue number in the PR title? https://devguide.python.org/pullrequest/#submitting

@erlend-aasland
Copy link
Contributor

@nanjekyejoannah There is an issue for this PR: https://bugs.python.org/issue44354

@nanjekyejoannah
Copy link
Contributor

Thanks, for the reminder @erlend-aasland , it looked like a trivial fix so I originally did not think opening an issue was relevant but am good with an issue

nanjekyejoannah
nanjekyejoannah reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the skip issue label, you can now please follow the issue reference guide to link an issue to this PR @graingert

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 10, 2021
@graingert graingert closed this Jul 10, 2021
@graingert graingert deleted the fix-ssl-module-deprecation-warning branch July 10, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
awaiting core review skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graingert @erlend-aasland @nanjekyejoannah @the-knights-who-say-ni @bedevere-bot