Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44364:Add non integral tests for sqrt() #26625

Merged
merged 3 commits into from
Jun 10, 2021
Merged

bpo-44364:Add non integral tests for sqrt() #26625

merged 3 commits into from
Jun 10, 2021

Conversation

ajthr
Copy link
Contributor

@ajthr ajthr commented Jun 9, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 9, 2021
mdickinson
mdickinson approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you! One minor suggested tweak to the news entry.

Misc/NEWS.d/next/Tests/2021-06-09-15-32-05.bpo-44364.zu9Zee.rst Outdated Show resolved Hide resolved
@ajthr @mdickinson
Update Misc/NEWS.d/next/Tests/2021-06-09-15-32-05.bpo-44364.zu9Zee.rst
307e962 
Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
@ajthr ajthr requested a review from mdickinson June 9, 2021 16:52
@mdickinson
Copy link
Member

Still LGTM. Will merge as soon as the checks complete. Thank you, and congratulations on your first contribution to CPython! (I'll follow up on your other PR shortly.)

@ajthr
Copy link
Contributor Author

ajthr commented Jun 10, 2021

Still LGTM. Will merge as soon as the checks complete. Thank you, and congratulations on your first contribution to CPython! (I'll follow up on your other PR shortly.)

ty :)

@mdickinson mdickinson merged commit 90cd433 into python:main Jun 10, 2021
@bedevere-bot
Copy link

@mdickinson: Please replace # with GH- in the commit message next time. Thanks!

@ajthr ajthr deleted the issue44364 branch June 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson Awaiting requested review from mdickinson

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajthr @mdickinson @bedevere-bot @the-knights-who-say-ni