Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure LICENSE file is regenerated even in PGO builds #27580

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Ensure LICENSE file is regenerated even in PGO builds #27580

merged 1 commit into from
Aug 3, 2021

Conversation

zooba
Copy link
Member

@zooba zooba commented Aug 3, 2021

No description provided.

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows skip issue skip news needs backport to 3.10 only security fixes labels Aug 3, 2021
@zooba zooba requested a review from a team as a code owner August 3, 2021 15:12
@zooba
Copy link
Member Author

zooba commented Aug 3, 2021

@pablogsal FYI, but I think I've got a fix for the current release, so we won't need to restart it.

@pablogsal
Copy link
Member

@pablogsal FYI, but I think I've got a fix for the current release, so we won't need to restart it.

Nice! If you find the fix for the current release too complex, I can restart the release after work.

@zooba
Copy link
Member Author

zooba commented Aug 3, 2021

The quick fix was to run the build twice to make sure the file is there, so it just added a few minutes. Looks like it's past the point where it failed the first time though, so the only reason we might rebuild is if it's too obvious that the build scripts came from my fork instead of the main repo (but I don't think that'll be obvious).

@zooba zooba merged commit 6871fd0 into python:main Aug 3, 2021
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6871fd0e8e5257f3ffebd1a1b2ca50e5f494e7f6 3.10

@zooba zooba added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Aug 3, 2021
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6871fd0e8e5257f3ffebd1a1b2ca50e5f494e7f6 3.10

@zooba zooba deleted the regen-fix branch August 3, 2021 15:54
zooba added a commit to zooba/cpython that referenced this pull request Aug 3, 2021
@zooba
Ensure LICENSE.txt file is generated even in PGO builds (pythonGH-27580)
9330922
@bedevere-bot
Copy link

GH-27582 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 3, 2021
pablogsal pushed a commit that referenced this pull request Aug 3, 2021
@zooba
Ensure LICENSE.txt file is generated even in PGO builds (GH-27580) (G…
4b46db6 
…H-27582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@zooba zooba

Labels
OS-windows skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zooba @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni