bpo-45235: Revert an argparse bugfix that caused a regression #29525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to 15 March
…faults (pythonGH-28420) (pythonGH-28443)" This reverts commit a18d522.
rhettinger
added
type-bug
ambv
reviewed
Nov 11, 2021
Comment on lines
-3117
to
-3122
| def test_set_defaults_on_subparser_with_namespace(self): | ||
| parser = argparse.ArgumentParser() | ||
| xparser = parser.add_subparsers().add_parser('X') | ||
| xparser.set_defaults(foo=1) | ||
| self.assertEqual(NS(foo=2), parser.parse_args(['X'], NS(foo=2))) | ||
|
|
There was a problem hiding this comment.
How about we keep this test and mark is as xfail until we bring back a better patch for the original issue?
There was a problem hiding this comment.
I think it would be better to leave it out. Also, any future changes will likely only go onto the main branch, so there is no value in leaving disabled tests in older versions. I would like to just do a clean revert. The open BPO issue will serve as the marker for future work to be done.
This was referenced Nov 11, 2021
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-29530 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2021
…GH-29525) * Revert "bpo-45235: Fix argparse overrides namespace with subparser defaults (pythonGH-28420) (pythonGH-28443)" This reverts commit a18d522. (cherry picked from commit 807f839) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2021
…GH-29525) * Revert "bpo-45235: Fix argparse overrides namespace with subparser defaults (pythonGH-28420) (pythonGH-28443)" This reverts commit a18d522. (cherry picked from commit 807f839) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
|
GH-29531 is a backport of this pull request to the 3.9 branch. |
jiasli
reviewed
Nov 12, 2021
| @@ -0,0 +1,3 @@ | |||
| Reverted an argparse bugfix that caused regression in the handling of | |||
| default arguments for subparsers. This prevented leaf level arguments from | |||
There was a problem hiding this comment.
The word "This" seems a little bit ambiguous to me. It can mean this PR (#29525) or the bugfix/regression.
rhettinger
pushed a commit
that referenced
this pull request
Nov 12, 2021
rhettinger
pushed a commit
that referenced
this pull request
Nov 12, 2021
1 task
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
…GH-29525) * Revert "bpo-45235: Fix argparse overrides namespace with subparser defaults (pythonGH-28420) (pythonGH-28443)" This reverts commit a18d522.
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
…GH-29525) * Revert "bpo-45235: Fix argparse overrides namespace with subparser defaults (pythonGH-28420) (pythonGH-28443)" This reverts commit a18d522.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45235