Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40077: Convert _pickle module to use heap types. #30884

Closed
wants to merge 6 commits into from

Conversation

CharlieZhao95
Copy link
Contributor

@CharlieZhao95 CharlieZhao95 commented Jan 25, 2022

Replace statically allocated types in _pickle module with heap allocated types:
use PyType_FromModuleAndSpec().

https://bugs.python.org/issue40077

@vstinner
Copy link
Member

Sadly, for now, converting static types to heap types is stale: https://bugs.python.org/issue40077#msg411630

@CharlieZhao95
Copy link
Contributor Author

Sadly, for now, converting static types to heap types is stale: https://bugs.python.org/issue40077#msg411630

Thanks for your reply! I'll keep this branch around and await to get permission from SC to continue with these changes.

@erlend-aasland
Copy link
Contributor

FYI: python/steering-council#99

@kumaraditya303
Copy link
Contributor

FYI: python/steering-council#99

@erlend-aasland What is the current status now? Should more extension modules be ported or not ?

@erlend-aasland
Copy link
Contributor

Petr and I are working on a PEP. When it is ready for review, we'll post it on Discourse/python-dev. When all comments have been addressed, we'll submit it to the SC and wait for either acceptance or rejection. I don't think there will be a change of status in the 3.11 development frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants