Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31533: fix broken link to OpenSSL docs #3674

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

felipeochoa
Copy link
Contributor

@felipeochoa felipeochoa commented Sep 20, 2017

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. The wiki is more up to date than https://linux.die.net/man/1/ciphers

You have not yet to sign the contributor agreement.

@felipeochoa
Copy link
Contributor Author

I've signed the CLA now and linked up my bpo and github accounts. I've also fixed the other occurrence of the dead link

@tiran
Copy link
Member

tiran commented Sep 20, 2017

Now let the magic if Miss Islington begin!

@tiran tiran merged commit 19e4d93 into python:master Sep 20, 2017
@miss-islington
Copy link
Contributor

Thanks @felipeochoa for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @felipeochoa and @tiran, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.

@bedevere-bot
Copy link

GH-3675 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2017
tiran pushed a commit to tiran/cpython that referenced this pull request Sep 20, 2017
@bedevere-bot
Copy link

GH-3676 is a backport of this pull request to the 2.7 branch.

@felipeochoa felipeochoa deleted the issue-31533 branch September 20, 2017 18:29
Mariatta pushed a commit that referenced this pull request Sep 20, 2017
Mariatta pushed a commit that referenced this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants