Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32422: Reduce lru_cache memory usage. #5008

Merged
merged 2 commits into from
Dec 25, 2017
Merged

bpo-32422: Reduce lru_cache memory usage. #5008

merged 2 commits into from
Dec 25, 2017

Conversation

methane
Copy link
Member

@methane methane commented Dec 25, 2017 •
edited by bedevere-bot
Loading

Remove GC header from link node.

https://bugs.python.org/issue32422

@methane
Reduce lru_cache memory usage.
a505ca5 
Remove GC header from link node.
serhiy-storchaka
serhiy-storchaka approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a news entry.

Mention that this change not just reduces lru_cache memory usage, but also reduces the burden on the GC.

@methane methane merged commit 3070b71 into python:master Dec 25, 2017
@methane methane deleted the lru-reduce-gc branch December 25, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot