Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33652: Remove __getstate__ and __setstate__ methods in typing. #7144

Merged
merged 1 commit into from
May 28, 2018
Merged

bpo-33652: Remove __getstate__ and __setstate__ methods in typing. #7144

merged 1 commit into from
May 28, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 28, 2018 •
edited by bedevere-bot
Loading

ilevkivskyi
ilevkivskyi approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ilevkivskyi ilevkivskyi merged commit 97b523d into python:master May 28, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7148 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@serhiy-storchaka @miss-islington
bpo-33652: Remove __getstate__ and __setstate__ methods in typing. (p…
3f55645 
…ythonGH-7144)

(cherry picked from commit 97b523d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request May 28, 2018
@miss-islington @serhiy-storchaka
bpo-33652: Remove __getstate__ and __setstate__ methods in typing. (G…
98b089e 
…H-7144)

(cherry picked from commit 97b523d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the typing-state branch October 22, 2018 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni