Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-33640, uuid.UUID doc: document endian of bytes parameter (GH-7263) #7386

Merged
merged 1 commit into from
Jun 4, 2018
Merged

[3.6] bpo-33640, uuid.UUID doc: document endian of bytes parameter (GH-7263) #7386

merged 1 commit into from
Jun 4, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 4, 2018 •
edited by bedevere-bot
Loading

The bytes parameter uses big endian.
(cherry picked from commit b75ec08)

Co-authored-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

https://bugs.python.org/issue33640

@farhaanbukhsh @miss-islington
bpo-33640, uuid.UUID doc: document endian of bytes parameter (pythonG…
c069bf3 
…H-7263)

The bytes parameter uses big endian.
(cherry picked from commit b75ec08)

Co-authored-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jun 4, 2018
Merged
vstinner
vstinner approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@farhaanbukhsh and @vstinner: Backport status check is done, and it's a success ✅ .

@Mariatta
Copy link
Member

Mariatta commented Jun 4, 2018

I've opened an issue to investigate why miss-islington did not automerge this PR: python/miss-islington#94

@Mariatta Mariatta mentioned this pull request Jun 4, 2018
Closed
@Mariatta
Copy link
Member

Mariatta commented Jun 4, 2018

The PR was not automerged because at that time, appveyor was a required status check, but it did not run.
Appveyor status check has been disabled now, so I'll get miss-islington to merge this.

@miss-islington
Copy link
Contributor Author

@farhaanbukhsh and @vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6a43d5f into python:3.6 Jun 4, 2018
@miss-islington
Copy link
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-b75ec08-3.6 branch June 4, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @Mariatta @vstinner @the-knights-who-say-ni @bedevere-bot @farhaanbukhsh