Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34632: Add the importlib.metadata module #9327

Closed
wants to merge 4 commits into from

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Sep 14, 2018

@brettcannon
Copy link
Member

Doc/library/importlib.rst Show resolved Hide resolved
and `metadata API
<https://setuptools.readthedocs.io/en/latest/pkg_resources.html#metadata-api>`_.

The standalone backport of this module provides more information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"stand-alone"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to address this on the next port, as this phrase is local to the CPython port.

Doc/library/importlib.rst Show resolved Hide resolved
Doc/library/importlib.rst Show resolved Hide resolved
Doc/library/importlib.rst Show resolved Hide resolved
Lib/importlib/metadata.py Show resolved Hide resolved
Doc/library/importlib.rst Show resolved Hide resolved
Lib/importlib/metadata.py Show resolved Hide resolved
Lib/importlib/metadata.py Show resolved Hide resolved
Lib/importlib/metadata.py Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@jaraco
Copy link
Member

jaraco commented Feb 20, 2019

Based on comments herein and other influences borne out by the public release of importlib_metadata, much has changed since this PR. We're going to want to restart this effort from the latest upstream codebase. There are only a couple of comments above that weren't addressed that will need to be addressed in a subsequent port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants