GH-95818: Skip incomplete frames in PyThreadState_GetFrame
#95886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Aug 11, 2022
•
markshannon
commented
- Issue: Weird test failures related to tracebacks #95818
iritkatriel
reviewed
Aug 11, 2022
| if (tstate->cframe->current_frame == NULL) { | ||
| _PyInterpreterFrame *f = tstate->cframe->current_frame; | ||
| while (f && _PyFrame_IsIncomplete(f)) { | ||
| f = f->previous; |
There was a problem hiding this comment.
Is previous guaranteed to be initialized in an incomplete frame?
There was a problem hiding this comment.
Yes. A _PyInterpreterFrame is never incomplete in the sense that it is partially initialized. "Incomplete" just means that the resulting frame object wouldn't be valid because stuff like MAKE_CELL hasn't run yet (or we just want to hide the frame).
iritkatriel
approved these changes
Aug 11, 2022
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-95890 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2022
…ythonGH-95886) (cherry picked from commit 1b46d11) Co-authored-by: Mark Shannon <mark@hotpy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.