Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-72719: Remove deprecated asyncore and asynchat modules #96580

Merged
merged 7 commits into from
Nov 8, 2022
Merged

gh-72719: Remove deprecated asyncore and asynchat modules #96580

merged 7 commits into from
Nov 8, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 5, 2022 •
edited
Loading

Several notes:

  1. I followed the same path as smtpd in gh-93243: Make smtpd private before porting its users #93246 It was suggested in Remove asyncore, asynchat and smtpd modules #72719 (comment) by @vstinner
  2. I've added TODO items about completely removing these modules in the future

PEP: https://peps.python.org/pep-0594/

@sobolevn sobolevn requested review from a team and vsajip as code owners September 5, 2022 14:18
@sobolevn sobolevn force-pushed the issue-72719 branch 2 times, most recently from 92a5bab to 97d7bc8 Compare September 5, 2022 14:29
theLastOfCats
theLastOfCats reviewed Sep 5, 2022
View reviewed changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@arhadthedev
Copy link
Member

I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible in asyncore but not in asyncio as soon as possible.

@sobolevn
Copy link
Member Author

Ping @pablogsal as release manager 🙂

@pablogsal
Copy link
Member

Ping @pablogsal as release manager 🙂

Thanks for checking with me! One note, the RM for 3.12 is @Yhg1s so he should probably also take a look

@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 99e3de9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
@arhadthedev arhadthedev mentioned this pull request Oct 3, 2022
Open
12 tasks
@arhadthedev
Copy link
Member

@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved.

@sobolevn @JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU…
9a49615 
…pzF3.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@hugovk hugovk mentioned this pull request Oct 28, 2022
Closed
@sobolevn sobolevn mentioned this pull request Oct 29, 2022
Merged
vstinner
vstinner reviewed Nov 3, 2022
View reviewed changes
Lib/test/support/asynchat.py Outdated Show resolved Hide resolved
Lib/test/support/asyncore.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Outdated
@@ -0,0 +1,3 @@
Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.

They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for the review!

@bedevere-bot bedevere-bot mentioned this pull request Nov 5, 2022
Closed
vstinner
vstinner reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove last references:

  • Doc/library/socketserver.rst
  • Doc/license.rst: update the module names

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

@vstinner
Copy link
Member

vstinner commented Nov 7, 2022

When I removed the module last year (commit), I even renamed the asyncore module to test.support._asyncore. But I don't mind to call it test.support.asyncore.

@giampaolo
Copy link
Contributor

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

sure, no problem

@sobolevn
Copy link
Member Author

sobolevn commented Nov 7, 2022

Done, all three - removed!

vstinner
vstinner reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?

Please keep the license, files are still around, they are just moved somewhere else.

Doc/license.rst Show resolved Hide resolved
vstinner
vstinner approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit e56e33d into python:main Nov 8, 2022
@vstinner
Copy link
Member

vstinner commented Nov 8, 2022

Merged, thanks. Let's see how it goes with Python 3.12.

@sobolevn
Copy link
Member Author

sobolevn commented Nov 8, 2022

Thank you for your guidance and help!
I feel happy now, removing old stuff is my kinda thing 😊 🎉

@vstinner
Copy link
Member

vstinner commented Nov 8, 2022

See also the discussion: Collaboration on handling Python 3.12 incompatible changes (distutils removal, invalid escape escape, etc.).

@opoplawski opoplawski mentioned this pull request Apr 1, 2023
Closed
@arhadthedev arhadthedev mentioned this pull request May 25, 2023
Closed
@honglei honglei mentioned this pull request Jun 18, 2023
Closed
@thebeanogamer thebeanogamer mentioned this pull request Jul 16, 2023
Open
SreekanthModupalli

This comment was marked as off-topic.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SreekanthModupalli SreekanthModupalli SreekanthModupalli left review comments

@theLastOfCats theLastOfCats theLastOfCats left review comments

@hugovk hugovk hugovk left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@vstinner vstinner vstinner approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@giampaolo giampaolo Awaiting requested review from giampaolo

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sobolevn @arhadthedev @pablogsal @bedevere-bot @vstinner @giampaolo @JelleZijlstra @hugovk @theLastOfCats @SreekanthModupalli