-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96577: Fixes buffer overrun in _msi module #96633
Conversation
zooba
commented
Sep 6, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: stack buffer overflow of Record Object in msilib #96577
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pointer to the variable that specifies the size, in TCHARs, of the buffer pointed to by the variable szResultBuf.
Pointer to the variable that specifies the size, in TCHARs, of the buffer pointed to by the variable szValueBuf.
@@ -0,0 +1 @@ | |||
Fixes a potential buffer overrun in :mod:`msilib`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may move this to the security category, but I'm fine with the Windows category.
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10, 3.11. |
(cherry picked from commit 4114bcc) Co-authored-by: Steve Dower <steve.dower@python.org>
GH-96655 is a backport of this pull request to the 3.11 branch. |
GH-96656 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit 4114bcc) Co-authored-by: Steve Dower <steve.dower@python.org>
GH-96657 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 4114bcc) Co-authored-by: Steve Dower <steve.dower@python.org>
GH-96658 is a backport of this pull request to the 3.8 branch. |
GH-96659 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 4114bcc) Co-authored-by: Steve Dower <steve.dower@python.org>