Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PEP 646 #12280

Closed
erictraut opened this issue Mar 2, 2022 · 5 comments · Fixed by #16354
Closed

Support for PEP 646 #12280

erictraut opened this issue Mar 2, 2022 · 5 comments · Fixed by #16354
Labels
affects-typeshed Anything that blocks a typeshed change feature meta Issues tracking a broad area of work priority-0-high topic-pep-646 PEP 646 (TypeVarTuple, Unpack)

Comments

@erictraut
Copy link

PEP 646 has been accepted for inclusion in Python 3.11. Both pyre and pyright support it currently.

Third-party libraries and typeshed stubs will probably avoid using this functionality until mypy offers some level of support for it.

Perhaps as a first step, mypy could implement a minimal understanding of TypeVarTuple, Unpack, and the new grammar change for *? This would allow libraries to start using the new facilities without generating false positive errors in mypy. This is a similar approach to the one for PEP 612 (ParamSpec) and PEP 634 (structural pattern matching).
@BvB93 BvB93 mentioned this issue Mar 3, 2022
Open
@97littleleaf11 97littleleaf11 mentioned this issue Mar 13, 2022
Closed
@JelleZijlstra JelleZijlstra added the topic-pep-646 PEP 646 (TypeVarTuple, Unpack) label Mar 19, 2022
@herman5 herman5 mentioned this issue Mar 23, 2022
Merged
@AlexWaygood AlexWaygood added affects-typeshed Anything that blocks a typeshed change meta Issues tracking a broad area of work labels Apr 10, 2022
@DMRobertson DMRobertson mentioned this issue Apr 11, 2022
Merged
@jorenham jorenham mentioned this issue Jun 2, 2022
Closed
@AlexWaygood AlexWaygood mentioned this issue Jun 15, 2022
Closed
@jasonpaulos jasonpaulos mentioned this issue Jun 21, 2022
Closed
@Avasam Avasam mentioned this issue Sep 4, 2022
Merged
@AlexWaygood AlexWaygood mentioned this issue Sep 9, 2022
Closed
5 tasks
@Avasam Avasam mentioned this issue Sep 19, 2022
Closed
@multimeric multimeric mentioned this issue Sep 23, 2022
Open
@tyralla
Copy link
Contributor

tyralla commented Nov 18, 2022

@jhance: I thought about giving it a try but then realised you already did a lot of work (at least #13105, #13210, #13211, #13586, #13889) that has been merged. Is there still much to do where others could help?

@DMRobertson DMRobertson mentioned this issue Dec 2, 2022
Merged
@uriyyo
Copy link
Member

uriyyo commented Feb 6, 2023

Hi all,
Do we have a list of things left to implement to support PEP 646 fully?

@xanderdunn xanderdunn mentioned this issue Feb 18, 2023
Closed
@jorenham jorenham mentioned this issue Mar 6, 2023
Closed
17 tasks
@ramonhagenaars ramonhagenaars mentioned this issue Mar 14, 2023
Open
@erictraut erictraut mentioned this issue Mar 21, 2023
Closed
@Zac-HD Zac-HD mentioned this issue Mar 29, 2023
Open
@erictraut erictraut mentioned this issue Apr 4, 2023
Open
@lagru lagru mentioned this issue May 2, 2023
Draft
@BvB93 BvB93 mentioned this issue May 8, 2023
Open
@julian-goettingen julian-goettingen mentioned this issue May 26, 2023
Closed
@mattijn mattijn mentioned this issue Jun 17, 2023
Merged
1 task
@killjoy1221 killjoy1221 mentioned this issue Jun 29, 2023
Closed
@asottile asottile mentioned this issue Jul 31, 2023
Merged
@mentalisttraceur mentalisttraceur mentioned this issue Aug 17, 2023
Closed
@vavanade
Copy link

What's the current state on this?

@AlexWaygood
Copy link
Member

What's the current state on this?

See #16242 (comment)

@lagru lagru mentioned this issue Oct 18, 2023
Closed
@Lordfirespeed
Copy link

With #16242 merged, is this issue resolved?

@ilevkivskyi ilevkivskyi mentioned this issue Oct 28, 2023
Merged
JukkaL pushed a commit that referenced this issue Oct 30, 2023
@ilevkivskyi @JelleZijlstra
Enable Unpack/TypeVarTuple support (#16354)
ad0e183 
Fixes #12280
Fixes #14697

In this PR:
* Enable `TypeVarTuple` and `Unpack` features.
* Delete the old blanket `--enable-incomplete-features` flag that was
deprecated a year ago.
* Switch couple corner cases to `PreciseTupleTypes` feature.
* Add the draft docs about the new feature.
* Handle a previously unhandled case where variadic tuple appears in
string formatting (discovered on mypy self-check, where
`PreciseTupleTypes` is already enabled).

---------

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@oremanj oremanj mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-typeshed Anything that blocks a typeshed change feature meta Issues tracking a broad area of work priority-0-high topic-pep-646 PEP 646 (TypeVarTuple, Unpack)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Unpack/TypeVarTuple support ilevkivskyi/mypy
8 participants
@JelleZijlstra @erictraut @97littleleaf11 @vavanade @tyralla @Lordfirespeed @uriyyo @AlexWaygood