Enable Unpack/TypeVarTuple support #16354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pycryptodome (https://github.com/Legrandin/pycryptodome)
- lib/Crypto/Protocol/DH.pyi:15: error: "Unpack" support is experimental, use --enable-incomplete-feature=Unpack to enable [misc]
pydantic (https://github.com/samuelcolvin/pydantic)
- pydantic/fields.py:175: error: "Unpack" support is experimental, use --enable-incomplete-feature=Unpack to enable [misc]
- pydantic/fields.py:182: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:214: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:218: error: "Unpack" support is experimental, use --enable-incomplete-feature=Unpack to enable [misc]
- pydantic/fields.py:705: error: "Unpack" support is experimental, use --enable-incomplete-feature=Unpack to enable [misc]
- pydantic/fields.py:762: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:766: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:772: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:778: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:788: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:794: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/fields.py:821: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/main.py:127: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/main.py:128: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/main.py:129: error: Unused "type: ignore" comment [unused-ignore]
- pydantic/main.py:883: error: "Unpack" support is experimental, use --enable-incomplete-feature=Unpack to enable [misc]
discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.08x slower (146.0s -> 157.6s)
(Performance measurements are based on a single noisy sample)
|
hauntsaninja
approved these changes
Oct 29, 2023
JukkaL
approved these changes
Oct 30, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12280
Fixes #14697
In this PR:
TypeVarTupleandUnpackfeatures.--enable-incomplete-featuresflag that was deprecated a year ago.PreciseTupleTypesfeature.PreciseTupleTypesis already enabled).