Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fancy new syntax for variadic types #16242

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

ilevkivskyi
Copy link
Member

This is the last significant thing I am aware of that is needed for PEP 646 support. After this and other currently open PRs are merged, I will make an additional pass grepping for usual suspects and verifying we didn't miss anything. Then we can flip the switch and announce this as supported.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

porcupine (https://github.com/Akuli/porcupine): typechecking got 1.73x slower (21.1s -> 36.6s)
(Performance measurements are based on a single noisy sample)

@hauntsaninja hauntsaninja merged commit f3bdf5c into python:master Oct 18, 2023
18 checks passed
@ilevkivskyi ilevkivskyi deleted the tvt-fancy branch October 18, 2023 10:10
@mrahtz
Copy link

mrahtz commented Oct 27, 2023

(Thank you for all your work on this, Ivan!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants