Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools as a dependency on Python 3.12? #15579

Closed
JukkaL opened this issue Jul 3, 2023 · 4 comments · Fixed by #16229
Closed

Add setuptools as a dependency on Python 3.12? #15579

JukkaL opened this issue Jul 3, 2023 · 4 comments · Fixed by #16229
Labels

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 3, 2023

Mypyc needs distutils or setuptools to run, but Python 3.12 no longer bundles distutils (PEP 632). This seems to imply that we need to include setuptools as a dependency of mypy (at least on Python 3.12 or later), or unbundle mypyc into a separate distribution on PyPI. Thoughts?

@eli-schwartz
Copy link
Contributor

One possible alternative is to teach mypyc to emit the relevant sources without compiling them, so that people can integrate it into other build systems. :D

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jul 3, 2023

I think fine to include setuptools as a dependency. We could also have a mypyc extra that includes it, like we do for dmypy or reports.

Eli's suggestion sounds great, but is little orthogonal

@AlexWaygood
Copy link
Member

We could also have a mypyc extra that includes it, like we do for dmypy or reports.

I'd personally prefer this, but agree that having it as an unconditional dependency would also probably be fine

@nickdrozd
Copy link
Contributor

I ran into this problem locally and in CI.

hauntsaninja added a commit to hauntsaninja/mypy that referenced this issue Oct 6, 2023
hauntsaninja added a commit to hauntsaninja/mypy that referenced this issue Oct 6, 2023
ilevkivskyi pushed a commit that referenced this issue Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants