Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stubtest to ignore python2 only magic methods #13290

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Allow stubtest to ignore python2 only magic methods #13290

merged 1 commit into from
Jul 30, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 30, 2022 •
edited
Loading

CC @JelleZijlstra @AlexWaygood
Refs python/typeshed#8443
Refs #12237

I will examine and remove other python2-only magic methods from typeshed later 🙂

JelleZijlstra
JelleZijlstra approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me; stubtest doesn't need to care if these methods are omitted in new stubs.

@sobolevn sobolevn merged commit 8919d2a into master Jul 30, 2022
@sobolevn sobolevn deleted the sobolevn-patch-2 branch July 30, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @JelleZijlstra