Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with custom ErrorCodes #15327

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented May 30, 2023

A class marked with allow_interpreted_subclasses=True implicitly supports serialization while also allowing it to be subclassed by pure Python code.

Fixes #15255

https://mypyc.readthedocs.io/en/latest/differences_from_python.html#pickling-and-copying-objects
https://mypyc.readthedocs.io/en/latest/native_classes.html#inheritance

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@svalentin svalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! I was scratching my head for a few days about this issue...

@svalentin svalentin merged commit 3d2f437 into python:master May 31, 2023
@cdce8p cdce8p deleted the fix-crash-ErrorCode branch May 31, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with custom plugin and ErrorCode
2 participants