Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypyc] Fix compilation of unreachable comprehensions #15721

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[mypyc] Fix compilation of unreachable comprehensions #15721

merged 1 commit into from
Feb 28, 2024

Conversation

ichard26
Copy link
Collaborator

Fixes mypyc/mypyc#816. Admittedly hacky.

@ichard26 ichard26 requested a review from JukkaL November 3, 2023 21:29
JukkaL
JukkaL approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is a kind of hacky, but it's still better than what we had before, and it's simple enough, so it doesn't seem too bad.

@JukkaL JukkaL merged commit f19b5d3 into python:master Feb 28, 2024
12 checks passed
@ichard26 ichard26 deleted the fix-unreachable-comprehensions branch February 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unreachable generator expressions fails to compile
2 participants
@ichard26 @JukkaL