Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stubs packages from stubinfo.py where the runtime package has added a py.typed file #16226

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Oct 4, 2023

All of these stubs packages have been removed from typeshed, due to the runtime package having added a py.typed file.

@JelleZijlstra
Copy link
Member

Seems like you have to update some tests that specifically use maxminddb.

@AlexWaygood
Copy link
Member Author

Seems like you have to update some tests that specifically use maxminddb.

apparently so 😠

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JelleZijlstra JelleZijlstra merged commit 10dfafe into python:master Oct 4, 2023
18 checks passed
@AlexWaygood AlexWaygood deleted the bad-install-types branch October 4, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants