Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow tuple types using len() #16237

Merged
merged 20 commits into from
Oct 21, 2023
Merged

Narrow tuple types using len() #16237

merged 20 commits into from
Oct 21, 2023

Commits on Oct 2, 2023

  1. Copy over the tests

    @ilevkivskyi
    ilevkivskyi committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a28617f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Add type narrowing logic

    @ilevkivskyi
    ilevkivskyi committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    77925e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Complete type narrowing logic

    @ilevkivskyi
    ilevkivskyi committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    81f10e1 View commit details
    Browse the repository at this point in the history

  2. End-to-end implementation

    @ilevkivskyi
    ilevkivskyi committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b854c4f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Tweaks and fixes

    @ilevkivskyi
    ilevkivskyi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5683f9d View commit details
    Browse the repository at this point in the history

  2. Some more tests and fixes

    @ilevkivskyi
    ilevkivskyi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e9cb9b7 View commit details
    Browse the repository at this point in the history

  3. Add TypeVarTuple tests

    @ilevkivskyi
    ilevkivskyi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9815637 View commit details
    Browse the repository at this point in the history

  4. More variadic tests; binder special-casing

    @ilevkivskyi
    ilevkivskyi committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8eb8900 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Docstring/comments; reorg code

    @ilevkivskyi
    ilevkivskyi committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    a03d3bf View commit details
    Browse the repository at this point in the history

  2. Fix one TODO (mixed unions)

    @ilevkivskyi
    ilevkivskyi committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    4cc35ec View commit details
    Browse the repository at this point in the history

  3. Partially fix another TODO

    @ilevkivskyi
    ilevkivskyi committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    34d2dd4 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into len-type-narrowing

    @ilevkivskyi
    ilevkivskyi committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    ab338ad View commit details
    Browse the repository at this point in the history

  5. Fix primer

    @ilevkivskyi
    ilevkivskyi committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    8844f69 View commit details
    Browse the repository at this point in the history

  6. Fix the fix

    @ilevkivskyi
    ilevkivskyi committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    12052ea View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. More consistent handling for Any in narrowing

    @ilevkivskyi
    ilevkivskyi committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9c21e44 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Gate precise tuple types behind a separate feature

    @ilevkivskyi
    ilevkivskyi committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    25396cf View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge remote-tracking branch 'upstream/master' into len-type-narrowing

    @ilevkivskyi
    ilevkivskyi committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    5b21778 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Address some feedback

    @ilevkivskyi
    ilevkivskyi committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    d84f38f View commit details
    Browse the repository at this point in the history

  2. More feedback; more corner cases; more tests

    @ilevkivskyi
    ilevkivskyi committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    ba196fd View commit details
    Browse the repository at this point in the history

  3. Handle unrelated corner case to avoid new false positives

    @ilevkivskyi
    ilevkivskyi committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    d676b23 View commit details
    Browse the repository at this point in the history