Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on unimported Any in TypedDict #16510

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #16498

Fix is trivial: no operations can be done with Required types before unwrapping (because they are not real types).

This comment has been minimized.

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I figured this would probably be a simple fix

test-data/unit/check-typeddict.test Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 8c8aa10 into python:master Nov 17, 2023
18 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-any-crash branch November 17, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mypy crashes when importing types_aiobotocore_s3
2 participants