Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on TypeGuard in __call__ #16516

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

ilevkivskyi
Copy link
Member

Fixes #16187

Note there may be some more similar crashes, I don't handle them all properly, for now I leave a TODO and replace the assert with if, so at least we should not crash on an unhandled case.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.08x faster (190.2s -> 176.1s)
(Performance measurements are based on a single noisy sample)

@JukkaL JukkaL merged commit 242ad2a into python:master Nov 22, 2023
18 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-tg-crash branch November 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(🐞) Crash with TypeGuard on __call__
2 participants