Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting enum members to "..." #16807

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add support for setting enum members to "..." #16807

merged 3 commits into from
Jan 22, 2024

Conversation

JelleZijlstra
Copy link
Member

Unblock python/typeshed#11299

(Explain how this PR changes mypy.)

@JelleZijlstra JelleZijlstra mentioned this pull request Jan 22, 2024
Closed
5 tasks
hauntsaninja
hauntsaninja approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be dedented? Are there any other situations in which this could come up?

@JelleZijlstra
Copy link
Member Author

I feel like outside enums we shouldn't allow = ....

@hauntsaninja hauntsaninja merged commit 7eab8a4 into python:master Jan 22, 2024
13 checks passed
@JelleZijlstra JelleZijlstra deleted the stubtenum branch January 22, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JelleZijlstra @hauntsaninja