Support type objects in functools.partial #17292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: websockets (https://github.com/aaugustin/websockets)
- src/websockets/legacy/server.py:1048: error: "type[WebSocketServerProtocol]" not callable [misc]
- src/websockets/legacy/client.py:496: error: "type[WebSocketClientProtocol]" not callable [misc]
isort (https://github.com/pycqa/isort)
- isort/exceptions.py:13: error: "Type[ISortError]" not callable [misc]
|
cdce8p
approved these changes
May 25, 2024
Comment on lines
-306
to
+311
| p = functools.partial(t, 1) # E: "Type[A]" not callable | ||
| p = functools.partial(t, 1) | ||
| reveal_type(p) # N: Revealed type is "functools.partial[__main__.A]" | ||
|
|
||
| p("a") # OK | ||
| p(1) # False negative | ||
| p(z=1) # False negative | ||
| p(1) # E: Argument 1 to "A" has incompatible type "int"; expected "str" | ||
| p(z=1) # E: Unexpected keyword argument "z" for "A" |
There was a problem hiding this comment.
Awesome that these are now fixed!
|
This is great, thanks @hauntsaninja! Looks like there's still a bug in the presence of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.