Add NewType #1939
Merged
Add NewType #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ... | ||
|
|
||
| However, at runtime, ``NewType('Derived', Base)`` will return a dummy function that | ||
| simply returns its argument. |
There was a problem hiding this comment.
Might want to show this by example, e.g.
def Derived(_x):
return _x
|
|
||
| def get_newtype_declaration(self, s: AssignmentStmt) -> Optional[CallExpr]: | ||
| """Returns the Newtype() call statement if `s` is a newtype declaration | ||
| or None otherwise.""" |
There was a problem hiding this comment.
Can you make this docstring follow the PEP 257 recommendation?
|
Done with the first round of code review. Hopefully it's as thorough as you requested! :-) |
|
|
||
| .. code-block:: python | ||
|
|
||
| def Derived(_x: Base) -> Base: |
There was a problem hiding this comment.
Since this is runtime, IMO it's better not to annotate it at all: just def Derived(_x): return _x.
|
Thanks for writing such great documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements
NewTypeas described in PEP 484 and in issue #1284. It also adds a variety of test cases to verifyNewTypeworks correctly when used and misused and adds information about usingNewTypeto the mypy docs.This pull request resolves #1284.