[mypyc] Add primitive ops for dictionary methods #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...and as usual Python 3.5 is totally busted. I will probably just disable this on Python 3.5. PR #8725 adds the corresponding |
|
@msullivan @JukkaL I switched to disabling the optimization for subclasses here too. Now tests pass on Python 3.5. |
|
I measured that this can make the ops at least 2x faster for small dictionaries. This is a great improvement! |
JukkaL
approved these changes
May 6, 2020
| @@ -1035,14 +1035,17 @@ def u(x: int) -> int: | |||
| d.update(x=x) | |||
| return d['x'] | |||
|
|
|||
| def get_content(d: Dict[int, int]) -> Tuple[List[int], List[int], List[Tuple[int, int]]]: | |||
| return list(d.keys()), list(d.values()), list(d.items()) | |||
There was a problem hiding this comment.
Add also tests for the "plain" primitive ops that don't create a list, such as by doing set(d.keys())?
Might be worth testing dict subclasses as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers both view and list versions (it looks like both are used relatively often, at least in mypy). This accompanies #8725 to account for cases where
keys/values/itemsappear in non-loop contexts.