Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 612: Updates from typing-sig discussions #1424

Merged
merged 37 commits into from
Jun 26, 2020
Merged

PEP 612: Updates from typing-sig discussions #1424

merged 37 commits into from
Jun 26, 2020

Conversation

mrkmndz
Copy link
Contributor

@mrkmndz mrkmndz commented Jun 10, 2020 •
edited
Loading

This PR updates PEP 612 following discussions on typing-sig

These updates include:

  • ParameterSpecification is abbreviated to ParamSpec
  • finite-length parameter modification via typing.type_variable_operators.Concatenate is integrated throughout the PEP
  • the ParametersOf counterproposal is discussed
  • a proposed but deferred solution for modifying named parameters is discussed
  • the prose has been edited for clarity
  • variable names have been shortened to make the code examples more compact

@gvanrossum
Copy link
Member

@mrkmndz I realize this is still a draft -- before you undraft it, could you fix the issue title and provide a brief summary of what's in this PR?

@mrkmndz
Copy link
Contributor Author

mrkmndz commented Jun 10, 2020

@mrkmndz I realize this is still a draft -- before you undraft it, could you fix the issue title and provide a brief summary of what's in this PR?

Will do!

@mrkmndz mrkmndz changed the title Updated PEP 612: Updates from typing-sig discussions Jun 10, 2020
grievejia
grievejia reviewed Jun 11, 2020
View reviewed changes
pep-0612.rst Outdated Show resolved Hide resolved
pep-0612.rst Outdated Show resolved Hide resolved
pep-0612.rst Show resolved Hide resolved
pep-0612.rst Outdated Show resolved Hide resolved
pep-0612.rst Outdated Show resolved Hide resolved
pep-0612.rst Show resolved Hide resolved
pep-0612.rst Outdated Show resolved Hide resolved
pep-0612.rst Show resolved Hide resolved
pep-0612.rst Outdated Show resolved Hide resolved
@mrkmndz mrkmndz marked this pull request as ready for review June 26, 2020 03:47
@gvanrossum gvanrossum merged commit d32dc02 into python:master Jun 26, 2020
@mrkmndz mrkmndz deleted the updated branch June 26, 2020 04:44
@layday layday mentioned this pull request Jul 19, 2020
Closed
AA-Turner pushed a commit to AA-Turner/peps that referenced this pull request Aug 15, 2020
@mrkmndz @AA-Turner
PEP 612: Updates from typing-sig discussions (python#1424)
3482941
mnm678 pushed a commit to mnm678/peps that referenced this pull request Oct 22, 2020
@mrkmndz @mnm678
PEP 612: Updates from typing-sig discussions (python#1424)
49befd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grievejia grievejia grievejia left review comments

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrkmndz @gvanrossum @grievejia @the-knights-who-say-ni