Support code highlighting

[ofek]

See: #1571 (comment)

Fine to try it in another PR, but looks like all that really is needed is to install pygments:

1. The script step calls make to turn plaintext PEPs into HTML, and I assume pygments is only needed here to add colour to the generated HTML files (I'm afk this week so cannot verify this assumption.now).
2. Then the deploy step calls deploy.bash which does make package to tar.gz the plaintext and generated files and images, and then calls aws to actually deploy the tar.gz to AWS.

[brettcannon]

Have you checked if this will work with the deployment of the PEPs on python.org?

[ofek]

How would one test that?

[Mariatta]

The process to build the PEPs from python.org is described here https://pythondotorg.readthedocs.io/pep_generation.html

[ofek]

django.db.utils.OperationalError: could not connect to server: No such file or directory
        Is the server running locally and accepting
        connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?

[ofek]

I'm having difficulty building the site

[ofek]

Could one of you please try?

[brettcannon]

We don't 'have any experience with the web site, so it would be best to ask on the pythondotorg repo instead of here.

[hugovk]

I was also unsuccessful, I tried both the Vagrant and manual methods from https://pythondotorg.readthedocs.io/install.html

[Mariatta]

Please report issue wrt pythondotorg guide in the GitHub.com/Python/pythondotorg repo

[ofek]

python/pythondotorg#1633

[ofek]

@brettcannon Seems to work python/pythondotorg#1633 (comment)

[ofek]

I rebased, should be good to merge now

[Mariatta]

Perhaps we should create requirements.txt and pin the versions ofdocutils and pygments.

[ofek]

Done!

[AA-Turner]

Perils of reading commit info from emails and not checking the latest! Feel free to bump the docutils/sphix reqs, they are current as of April 2020, so 0.17.z / 4.y.z may be more appropriate.

A

[ofek]

Pushed commit!

[AA-Turner]

Only question I'd have is if better to pin to compatible releases or all future? (~= vs >=) - historically been unpinned so I think that means the latest release has always been used.

(but I am not best placed to make this call, as no idea if e.g. previously there have been breaking changes to PEP rendering due to dependency changes, or the risk appetite for this in the future vs new features that may or may not be used)

A

[ofek]

Okay, changed it back

[ofek]

all good to merge?

[ofek]

is there any other concern here?

[brettcannon]

@ofek matter of time to look at the PR (which I have), deciding if we want it, and then watching python.org/dev/peps to make sure nothing breaks.

[ofek]

Any update on this?

[brettcannon]

None from me, but I'm not the only PEP editor. I suspect we are all just busy with other stuff at the moment.

[JelleZijlstra]

Since it's been so long I'm going to re-trigger CI just to make sure. If it's still good I'm for merging this though.