Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reSTify 5 PEPs #276

Merged
merged 2 commits into from
Jun 2, 2017
Merged

reSTify 5 PEPs #276

merged 2 commits into from
Jun 2, 2017

Conversation

csabella
Copy link
Contributor

For #4.

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one clarifying question.

pep-0342.txt Outdated

New generator method: ``send(value)``

A new method for generator-iterators is proposed, called ``send()``. It
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to double-check that this indentation ends up looking okay in the final HTML?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettcannon Yes, it had looked good (like the original) in the html, but I went back and checked PEP-12 and see your point. I should use 4 spaces to indent if it's a block quote. But, looking at it fresh, maybe I should make the 'New generator method:' type lines into subheaders. I'll rework it.

@brettcannon brettcannon merged commit 329ed7e into python:master Jun 2, 2017
@brettcannon
Copy link
Member

Thanks!

@csabella csabella deleted the pep236 branch June 4, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants